Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix _utf8, introduce _unicode #23

Merged
merged 1 commit into from
May 28, 2024
Merged

fix _utf8, introduce _unicode #23

merged 1 commit into from
May 28, 2024

Conversation

pevans96
Copy link
Contributor

@pevans96 pevans96 commented May 23, 2024 •
edited
Loading

Goal

Fix

binascii.crc32(_utf8(key)) & 0xffffffff
TypeError: a bytes-like object is required, not 'str'

Implementation

Return bytes instead of a string from _utf8
Introduce _unicode to return a string

@pevans96 pevans96 self-assigned this May 23, 2024
@pevans96 pevans96 changed the title fix _utf8, return bytes fix _utf8, introduce _unicode May 23, 2024
@jehiah jehiah added the bug label May 23, 2024
@pevans96 pevans96 merged commit 8023d9d into bitly:master May 28, 2024
0 of 2 checks passed
@pevans96 pevans96 deleted the fix_str_need_bytes_23 branch May 28, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jehiah jehiah jehiah approved these changes

Assignees

@pevans96 pevans96

Labels
bug
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pevans96 @jehiah